chore(clerk-js): Fix broken Organization methods #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c0bf9fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chanioxaris
approved these changes
Oct 12, 2023
| rotatingTokenNonce, | ||
| }, | ||
| { forceUpdateClient: true }, |
There was a problem hiding this comment.
Don't we need to include this parameter as well?
Merged
dimkl
reviewed
Oct 12, 2023
| '@clerk/types': patch | ||
| --- | ||
|
|
||
| Fix methods in clerk-js that consumede paginated endpoints in order to retrieve single resources. |
There was a problem hiding this comment.
🙃 Should we replace consumede with consume ?
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes 2 methods that seems to be flawed.
https://github.com/clerkinc/javascript/blob/214f658cf79983b8b44ae3228b0500d88e215345/packages/clerk-js/src/core/resources/Organization.ts#L325
https://github.com/clerkinc/javascript/blob/214f658cf79983b8b44ae3228b0500d88e215345/packages/clerk-js/src/core/clerk.ts#L1086
To provide you with more context, these 2 methods rely on endpoints that resolve with paginated data and the iterate through them and filter the array based on an organizationID. This concept is flawed, as there is great chance that the organization id you are looking for, might not be part of the first page of the results.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore